Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overly greedy $scope->getType() calls in ImpossibleInstanceOfRule #2098

Merged
merged 2 commits into from Dec 13, 2022
Merged

Prevent overly greedy $scope->getType() calls in ImpossibleInstanceOfRule #2098

merged 2 commits into from Dec 13, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 13, 2022 •
edited

@ondrejmirtes
Copy link
Member

FYI this could have been a single PR ;)

It doesn't make much sense to open a bunch of related PRs at the same time:

  1. You're risking conflicts.
  2. It'd be tedious to apply learnings from the first PR in all the other PRs.

Instead, open a single PR and wait for it to be merged. That way both of these problems are solved.

And these are pretty simple PRs only with a few lines changed...

@ondrejmirtes ondrejmirtes merged commit 93a741e into phpstan:1.9.x Dec 13, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the unnecessary-getType branch December 13, 2022 15:41
@staabm
Copy link
Contributor Author

staabm commented Dec 13, 2022 •
edited

And these are pretty simple PRs only with a few lines changed...

I thought it would be easier to review in smaller PRs.. but I am fine with a big one.

fwiw, 1.9.3 vs. 1.9.x-dev has ~10.000 less getType() calls after these PRs :)

bin/phpstan --debug -vvv

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @ondrejmirtes