From 07101093f6e052004bc0a48d1ee70c21f1f5b34e Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Thu, 1 Dec 2022 15:15:47 +0100
Subject: [PATCH] DateTimeZoneConstructorThrowTypeExtension

---
 conf/config.neon                              |  5 ++
 ...eTimeZoneConstructorThrowTypeExtension.php | 50 +++++++++++++++++++
 ...CheckedExceptionInMethodThrowsRuleTest.php |  4 ++
 .../data/missing-exception-method-throws.php  | 10 ++++
 4 files changed, 69 insertions(+)
 create mode 100644 src/Type/Php/DateTimeZoneConstructorThrowTypeExtension.php

diff --git a/conf/config.neon b/conf/config.neon
index 24d0a2bea9..27369f0126 100644
--- a/conf/config.neon
+++ b/conf/config.neon
@@ -1347,6 +1347,11 @@ services:
 		tags:
 			- phpstan.dynamicStaticMethodThrowTypeExtension
 
+	-
+		class: PHPStan\Type\Php\DateTimeZoneConstructorThrowTypeExtension
+		tags:
+			- phpstan.dynamicStaticMethodThrowTypeExtension
+
 	-
 		class: PHPStan\Type\Php\DsMapDynamicReturnTypeExtension
 		tags:
diff --git a/src/Type/Php/DateTimeZoneConstructorThrowTypeExtension.php b/src/Type/Php/DateTimeZoneConstructorThrowTypeExtension.php
new file mode 100644
index 0000000000..4240b2b85f
--- /dev/null
+++ b/src/Type/Php/DateTimeZoneConstructorThrowTypeExtension.php
@@ -0,0 +1,50 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use DateTimeZone;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicStaticMethodThrowTypeExtension;
+use PHPStan\Type\NeverType;
+use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\TypeUtils;
+use function count;
+
+class DateTimeZoneConstructorThrowTypeExtension implements DynamicStaticMethodThrowTypeExtension
+{
+
+	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === '__construct' && $methodReflection->getDeclaringClass()->getName() === DateTimeZone::class;
+	}
+
+	public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
+	{
+		if (count($methodCall->getArgs()) === 0) {
+			return null;
+		}
+
+		$valueType = $scope->getType($methodCall->getArgs()[0]->value);
+		$constantStrings = TypeUtils::getConstantStrings($valueType);
+
+		foreach ($constantStrings as $constantString) {
+			try {
+				new DateTimeZone($constantString->getValue());
+			} catch (\Exception $e) { // phpcs:ignore
+				return $methodReflection->getThrowType();
+			}
+
+			$valueType = TypeCombinator::remove($valueType, $constantString);
+		}
+
+		if (!$valueType instanceof NeverType) {
+			return $methodReflection->getThrowType();
+		}
+
+		return null;
+	}
+
+}
diff --git a/tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php b/tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php
index 9f195bb503..d085543b84 100644
--- a/tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php
+++ b/tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php
@@ -40,6 +40,10 @@ public function testRule(): void
 				'Method MissingExceptionMethodThrows\Foo::doLorem2() throws checked exception InvalidArgumentException but it\'s missing from the PHPDoc @throws tag.',
 				34,
 			],
+			[
+				'Method MissingExceptionMethodThrows\Foo::dateTimeZoneDoesThrows() throws checked exception Exception but it\'s missing from the PHPDoc @throws tag.',
+				95,
+			],
 		]);
 	}
 
diff --git a/tests/PHPStan/Rules/Exceptions/data/missing-exception-method-throws.php b/tests/PHPStan/Rules/Exceptions/data/missing-exception-method-throws.php
index 8914d535d9..51cd4b0ef0 100644
--- a/tests/PHPStan/Rules/Exceptions/data/missing-exception-method-throws.php
+++ b/tests/PHPStan/Rules/Exceptions/data/missing-exception-method-throws.php
@@ -85,4 +85,14 @@ private function throwsInterface(): void
 
 	}
 
+	public function dateTimeZoneDoesNotThrow(): void
+	{
+		new \DateTimeZone('UTC');
+	}
+
+	public function dateTimeZoneDoesThrows(string $tz): void
+	{
+		new \DateTimeZone($tz);
+	}
+
 }