-
Notifications
You must be signed in to change notification settings - Fork 426
/
BooleanAndConstantConditionRuleTest.php
228 lines (211 loc) · 4.48 KB
/
BooleanAndConstantConditionRuleTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Comparison;
use PHPStan\Rules\Rule;
use PHPStan\Testing\RuleTestCase;
/**
* @extends RuleTestCase<BooleanAndConstantConditionRule>
*/
class BooleanAndConstantConditionRuleTest extends RuleTestCase
{
private bool $treatPhpDocTypesAsCertain;
protected function getRule(): Rule
{
return new BooleanAndConstantConditionRule(
new ConstantConditionRuleHelper(
new ImpossibleCheckTypeHelper(
$this->createReflectionProvider(),
$this->getTypeSpecifier(),
[],
$this->treatPhpDocTypesAsCertain,
),
$this->treatPhpDocTypesAsCertain,
),
$this->treatPhpDocTypesAsCertain,
);
}
protected function shouldTreatPhpDocTypesAsCertain(): bool
{
return $this->treatPhpDocTypesAsCertain;
}
public function testRule(): void
{
$this->treatPhpDocTypesAsCertain = true;
$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
$this->analyse([__DIR__ . '/data/boolean-and.php'], [
[
'Left side of && is always true.',
15,
],
[
'Right side of && is always true.',
19,
],
[
'Left side of && is always false.',
24,
],
[
'Right side of && is always false.',
27,
],
[
'Result of && is always false.',
30,
],
[
'Right side of && is always true.',
33,
],
[
'Right side of && is always true.',
36,
],
[
'Right side of && is always true.',
39,
],
[
'Result of && is always false.',
50,
],
[
'Result of && is always true.',
54,
$tipText,
],
[
'Result of && is always false.',
60,
],
[
'Result of && is always true.',
64,
//$tipText,
],
[
'Result of && is always false.',
66,
//$tipText,
],
[
'Result of && is always false.',
125,
],
[
'Left side of && is always false.',
139,
],
[
'Right side of && is always false.',
141,
],
[
'Left side of && is always true.',
145,
],
[
'Right side of && is always true.',
147,
],
]);
}
public function testDoNotReportPhpDoc(): void
{
$this->treatPhpDocTypesAsCertain = false;
$this->analyse([__DIR__ . '/data/boolean-and-not-phpdoc.php'], [
[
'Left side of && is always true.',
24,
],
[
'Right side of && is always true.',
30,
],
]);
}
public function testReportPhpDoc(): void
{
$this->treatPhpDocTypesAsCertain = true;
$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';
$this->analyse([__DIR__ . '/data/boolean-and-not-phpdoc.php'], [
[
'Result of && is always false.',
14,
$tipText,
],
[
'Left side of && is always true.',
24,
],
[
'Left side of && is always true.',
27,
$tipText,
],
[
'Right side of && is always true.',
30,
],
[
'Right side of && is always true.',
33,
$tipText,
],
]);
}
public function dataTreatPhpDocTypesAsCertainRegression(): array
{
return [
[
true,
],
[
false,
],
];
}
/**
* @dataProvider dataTreatPhpDocTypesAsCertainRegression
*/
public function testTreatPhpDocTypesAsCertainRegression(bool $treatPhpDocTypesAsCertain): void
{
$this->treatPhpDocTypesAsCertain = $treatPhpDocTypesAsCertain;
$this->analyse([__DIR__ . '/data/boolean-and-treat-phpdoc-types-regression.php'], []);
}
public function testBugComposerDependentVariables(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-composer-dependent-variables.php'], []);
}
public function testBug2231(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/../../Analyser/data/bug-2231.php'], [
[
'Result of && is always false.',
21,
],
]);
}
public function testBug1746(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-1746.php'], [
[
'Left side of && is always true.',
20,
],
]);
}
public function testBug4666(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-4666.php'], []);
}
public function testBug2870(): void
{
$this->checkAlwaysTrueCheckTypeFunctionCall = true;
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-2870.php'], []);
}
}