/
InstantiationRuleTest.php
397 lines (367 loc) · 10.8 KB
/
InstantiationRuleTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Classes;
use PHPStan\Php\PhpVersion;
use PHPStan\Rules\ClassCaseSensitivityCheck;
use PHPStan\Rules\FunctionCallParametersCheck;
use PHPStan\Rules\NullsafeCheck;
use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
use PHPStan\Rules\Properties\PropertyReflectionFinder;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleLevelHelper;
use PHPStan\Testing\RuleTestCase;
use const PHP_VERSION_ID;
/**
* @extends RuleTestCase<InstantiationRule>
*/
class InstantiationRuleTest extends RuleTestCase
{
protected function getRule(): Rule
{
$broker = $this->createReflectionProvider();
return new InstantiationRule(
$broker,
new FunctionCallParametersCheck(new RuleLevelHelper($broker, true, false, true, false), new NullsafeCheck(), new PhpVersion(80000), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true),
new ClassCaseSensitivityCheck($broker, true),
);
}
public function testInstantiation(): void
{
if (!self::$useStaticReflectionProvider && PHP_VERSION_ID >= 70400) {
$this->markTestSkipped('Test does not run on PHP 7.4 because of referencing parent:: without parent class.');
}
$this->analyse(
[__DIR__ . '/data/instantiation.php'],
[
[
'Class TestInstantiation\InstantiatingClass constructor invoked with 0 parameters, 1 required.',
15,
],
[
'TestInstantiation\InstantiatingClass::doFoo() calls new parent but TestInstantiation\InstantiatingClass does not extend any class.',
18,
],
[
'Class TestInstantiation\FooInstantiation does not have a constructor and must be instantiated without any parameters.',
26,
],
[
'Instantiated class TestInstantiation\FooBarInstantiation not found.',
27,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Class TestInstantiation\BarInstantiation constructor invoked with 0 parameters, 1 required.',
28,
],
[
'Instantiated class TestInstantiation\LoremInstantiation is abstract.',
29,
],
[
'Cannot instantiate interface TestInstantiation\IpsumInstantiation.',
30,
],
[
'Instantiated class Test not found.',
33,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Class DatePeriod constructor invoked with 0 parameters, 1-4 required.',
36,
],
[
'Using self outside of class scope.',
39,
],
[
'Using static outside of class scope.',
40,
],
[
'Using parent outside of class scope.',
41,
],
[
'Class TestInstantiation\InstantiatingClass constructor invoked with 0 parameters, 1 required.',
57,
],
[
'Class TestInstantiation\FooInstantiation referenced with incorrect case: TestInstantiation\FOOInstantiation.',
64,
],
[
'Class TestInstantiation\FooInstantiation does not have a constructor and must be instantiated without any parameters.',
64,
],
[
'Class TestInstantiation\BarInstantiation referenced with incorrect case: TestInstantiation\BARInstantiation.',
65,
],
[
'Class TestInstantiation\BarInstantiation constructor invoked with 0 parameters, 1 required.',
65,
],
[
'Class TestInstantiation\BarInstantiation referenced with incorrect case: TestInstantiation\BARInstantiation.',
66,
],
[
'Class TestInstantiation\ClassExtendsProtectedConstructorClass constructor invoked with 0 parameters, 1 required.',
94,
],
[
'Cannot instantiate class TestInstantiation\ExtendsPrivateConstructorClass via private constructor TestInstantiation\PrivateConstructorClass::__construct().',
104,
],
[
'Class TestInstantiation\ExtendsPrivateConstructorClass constructor invoked with 0 parameters, 1 required.',
104,
],
[
'Cannot instantiate class TestInstantiation\PrivateConstructorClass via private constructor TestInstantiation\PrivateConstructorClass::__construct().',
110,
],
[
'Cannot instantiate class TestInstantiation\ProtectedConstructorClass via protected constructor TestInstantiation\ProtectedConstructorClass::__construct().',
111,
],
[
'Cannot instantiate class TestInstantiation\ClassExtendsProtectedConstructorClass via protected constructor TestInstantiation\ProtectedConstructorClass::__construct().',
112,
],
[
'Cannot instantiate class TestInstantiation\ExtendsPrivateConstructorClass via private constructor TestInstantiation\PrivateConstructorClass::__construct().',
113,
],
[
'Parameter #1 $message of class Exception constructor expects string, int given.',
117,
],
[
'Parameter #2 $code of class Exception constructor expects int, string given.',
117,
],
[
'Class TestInstantiation\NoConstructor referenced with incorrect case: TestInstantiation\NOCONSTRUCTOR.',
127,
],
[
'Class class@anonymous/tests/PHPStan/Rules/Classes/data/instantiation.php:137 constructor invoked with 3 parameters, 1 required.',
137,
],
[
'Instantiated class UndefinedClass1 not found.',
169,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Instantiated class UndefinedClass2 not found.',
172,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Instantiated class UndefinedClass3 not found.',
179,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Class TestInstantiation\FinalClass does not have a constructor and must be instantiated without any parameters.',
190,
],
[
'Class TestInstantiation\ClassWithFinalConstructor constructor invoked with 0 parameters, 1 required.',
206,
],
[
'Class TestInstantiation\ConstructorComingFromAnInterface constructor invoked with 0 parameters, 1 required.',
229,
],
[
'Class TestInstantiation\AbstractClassWithFinalConstructor constructor invoked with 1 parameter, 0 required.',
245,
],
[
'Class TestInstantiation\AbstractConstructor constructor invoked with 0 parameters, 1 required.',
257,
],
[
'Class TestInstantiation\ClassExtendingAbstractConstructor constructor invoked with 0 parameters, 1 required.',
273,
],
],
);
}
public function testSoap(): void
{
$this->analyse(
[__DIR__ . '/data/instantiation-soap.php'],
[
[
'Parameter #2 $string of class SoapFault constructor expects string, int given.',
6,
],
],
);
}
public function testClassExists(): void
{
$this->analyse([__DIR__ . '/data/instantiation-class-exists.php'], []);
}
public function testBug3404(): void
{
$this->analyse([__DIR__ . '/data/bug-3404.php'], [
[
'Class finfo constructor invoked with 3 parameters, 0-2 required.',
7,
],
]);
}
public function testOldStyleConstructorOnPhp8(): void
{
if (PHP_VERSION_ID < 80000) {
$this->markTestSkipped('Test requires PHP 8.0');
}
$this->analyse([__DIR__ . '/data/php80-constructor.php'], [
[
'Class OldStyleConstructorOnPhp8 does not have a constructor and must be instantiated without any parameters.',
13,
],
[
'Class OldStyleConstructorOnPhp8 does not have a constructor and must be instantiated without any parameters.',
20,
],
]);
}
public function testOldStyleConstructorOnPhp7(): void
{
if (PHP_VERSION_ID >= 80000) {
$this->markTestSkipped('Test requires PHP 7.x');
}
$this->analyse([__DIR__ . '/data/php80-constructor.php'], [
[
'Class OldStyleConstructorOnPhp8 constructor invoked with 0 parameters, 1 required.',
19,
],
]);
}
public function testBug4030(): void
{
$this->analyse([__DIR__ . '/data/bug-4030.php'], []);
}
public function testPromotedProperties(): void
{
if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
$this->markTestSkipped('Test requires PHP 8.0.');
}
$this->analyse([__DIR__ . '/data/instantiation-promoted-properties.php'], [
[
'Parameter #2 $bar of class InstantiationPromotedProperties\Foo constructor expects array<string>, array<int, int> given.',
30,
],
[
'Parameter #2 $bar of class InstantiationPromotedProperties\Bar constructor expects array<string>, array<int, int> given.',
33,
],
]);
}
public function testBug4056(): void
{
$this->analyse([__DIR__ . '/data/bug-4056.php'], []);
}
public function testNamedArguments(): void
{
if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
$this->markTestSkipped('Test requires PHP 8.0.');
}
$this->analyse([__DIR__ . '/data/instantiation-named-arguments.php'], [
[
'Missing parameter $j (int) in call to InstantiationNamedArguments\Foo constructor.',
15,
],
[
'Unknown parameter $z in call to InstantiationNamedArguments\Foo constructor.',
16,
],
]);
}
public function testBug4471(): void
{
$this->analyse([__DIR__ . '/data/bug-4471.php'], [
[
'Instantiated class Bug4471\Baz not found.',
19,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Instantiated class Bug4471\Foo is abstract.',
24,
],
[
'Cannot instantiate interface Bug4471\Bar.',
27,
],
]);
}
public function testBug1711(): void
{
$this->analyse([__DIR__ . '/data/bug-1711.php'], []);
}
public function testBug3425(): void
{
$this->analyse([__DIR__ . '/data/bug-3425.php'], [
[
'Parameter #1 $iterator of class RecursiveIteratorIterator constructor expects T of IteratorAggregate|RecursiveIterator, Generator<int, int, mixed, void> given.',
5,
],
]);
}
public function testBug5002(): void
{
$this->analyse([__DIR__ . '/data/bug-5002.php'], []);
}
public function testBug4681(): void
{
if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
$this->markTestSkipped('Test requires PHP 8.0.');
}
$this->analyse([__DIR__ . '/data/bug-4681.php'], []);
}
public function testFirstClassCallable(): void
{
if (PHP_VERSION_ID < 80100 || !self::$useStaticReflectionProvider) {
$this->markTestSkipped('Test requires PHP 8.1 and static reflection.');
}
// handled by a different rule
$this->analyse([__DIR__ . '/data/first-class-instantiation-callable.php'], []);
}
public function testEnumInstantiation(): void
{
if (PHP_VERSION_ID < 80100) {
$this->markTestSkipped('Test requires PHP 8.1.');
}
$this->analyse([__DIR__ . '/data/enum-instantiation.php'], [
[
'Cannot instantiate enum EnumInstantiation\Foo.',
9,
],
[
'Cannot instantiate enum EnumInstantiation\Foo.',
14,
],
[
'Cannot instantiate enum EnumInstantiation\Foo.',
21,
],
]);
}
public function testBug6370(): void
{
$this->analyse([__DIR__ . '/data/bug-6370.php'], [
[
'Parameter #1 $something of class Bug6370\A constructor expects string, int given.',
45,
],
]);
}
}