Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong deprecation error from when parent::deprecatedMethod() called from trait #52

Open
mvorisek opened this issue Nov 27, 2021 · 0 comments

Comments

@mvorisek
Copy link

mvorisek commented Nov 27, 2021

code https://github.com/atk4/data/blob/bb1c18f5dc583fca7dd372f98a0172fe66663057/src/Persistence/Sql/Postgresql/PlatformTrait.php#L115

ci https://github.com/atk4/data/runs/4342242942?check_suite_focus=true#step:11:16

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Persistence/Sql/Postgresql/PlatformTrait.php (in context of anonymous class)  
 ------ ---------------------------------------------------------------------------------- 
  115    Call to method getCreateTableSQL() of deprecated class                            
         Doctrine\DBAL\Platforms\AbstractPlatform:                                         
         Use {@link PostgreSQLPlatform} instead.                                           
 ------ ---------------------------------------------------------------------------------- 

trait is implemented in anonymous class https://github.com/atk4/data/blob/bb1c18f5dc583fca7dd372f98a0172fe66663057/src/Persistence/Sql/Connection.php#L279

thus parent::getCreateTableSQL(... call inside the trait refers to (by the phpstan error recommended) PostgreSQLPlatform class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant