Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #624

Open
andypost opened this issue Apr 30, 2024 · 0 comments
Open

PHP 8.4 support #624

andypost opened this issue Apr 30, 2024 · 0 comments

Comments

@andypost
Copy link

I started testing Drupal 11 with PHP 8.4 and faced issues because of https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

I did patch some code (will provide PR) but still getting deprecation warnings from mocks

Probably the \Prophecy\Doubler\ClassPatch\DisableConstructorPatch::apply() needs changes

    OK (6 tests, 154 assertions)
    
    Other deprecation notices (2)
    
      1x:
    Double\Drupal\Core\Cache\Context\CacheContextsManager\P1::__construct():
    Implicitly marking parameter $container as nullable is deprecated, the
    explicit nullable type must be used instead
        1x in VariationCacheTest::setUp from Drupal\Tests\Core\Cache
    
      1x:
    Double\Drupal\Core\Cache\Context\CacheContextsManager\P1::__construct():
    Implicitly marking parameter $contexts as nullable is deprecated, the
    explicit nullable type must be used instead
        1x in VariationCacheTest::setUp from Drupal\Tests\Core\Cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant