Support standalone and nullable types for true, false, and null. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Sep 17, 2022
|
Question in general. Since true isn't a builtin type until PHP8.2, the code that is being mocked shouldn't have true as a standalone type. So how do choose what to prevent via versioning and what not? |
Make true type declarations version checked.
|
Hoping I get a comment from the above. As I'm changing a lot of for #535 that may require this type of version checking. |
|
@kschatzle not sure what the question means really? You have the PHP version checks in place that look correct, to me at least Can you rebase please? |
|
ok I fixed the conflict and fixed an issue with true handling - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.