New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please allow PHP 8.2 in composer.json #556
Comments
Yes, please. I had to set composer platform.php to 8.1 to be able to install phpunit v9 (which depends on prophecy). |
We can't really allow it until the new features are all supported or at least error with sensible messages; this will require someone to go through the various new features and make a list You can use --ignore-platform-req=PHP with composer to try things out for now |
Maybe the "<8.2" can be removed - so at least executing with PHP8.2 is possible. We are testing codebase with different php versions. Using Can be said, that new PHP8.2 language features are not supported yet. |
Agreed. Since prophecy is a direct dependency in phpunit 9, blocking PHP 8.2 here forces quite a few repositories to go with It would be great if composer.json could allow PHP 8.2 already, even if prophecy did not implement all features or fixes just yet. What do you think? |
We can't do that, there's a high probability that 8.3 will break prophecy (there hasn't really been a PHP minor that didn't break something) I think teams testing with pre-release versions of PHP should be ok with adding an extra composer flag to their edge builds |
Than change to <8.3 in the constraint. Not agreeing on that. We start to test early to get things done and look how dependencies are doing, helping or reporting it if there are problems (if reasonable doable). So, can we hope on a change with PHP8.2.0 release than at least "please" ? |
There are zero service guarantees about when prophecy is going to support new PHP versions; it depends on the community and maintainers doing the work The things that need to happen would be:
All but 3 can be done without maintainer permissions |
This needs the quirk --ignore-platform-req=php+ in tests.yml since prophecy as a direct phpunit dependency does not allow PHP 8.2 yet, even though html-sanitizer does not use prophecy. See phpspec/prophecy#556
Alright. Thanks for feedback! |
This needs the quirk --ignore-platform-req=php+ in tests.yml since prophecy as a direct phpunit dependency does not allow PHP 8.2 yet, even though html-sanitizer does not use prophecy. See phpspec/prophecy#556
So that means PhpUnit (which uses PS: What works as a workaround is adding this to
|
@danon that would not work if you "need/want" prophecy but also PHP8.2. |
@sbuerk I need PhpUnit on PHP 8.2, and it also uses |
This patch shifts some functional test executions in CI workflows to PHP8.2. Thus enabling test coverage for new PHP8.2 version in a early stage. For nightly we only can active it for `locked` runs, as prophecy/prophecy is not allowed to be installed with PHP8.2 currently. See: phpspec/prophecy#556 Backport to 11.5 is skipped for now due some issues in "doctrine/dbal 2.x" with PHP8.2. Resolves: #98109 Releases: main Change-Id: I02c4dc4bd3cdd589330b038463ed58a384e3d70d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75404 Tested-by: core-ci <typo3@b13.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
PHPUnit 8.5 and PHPUnit 9.5 work "just fine" on PHP 8.2. Until this issue is resolved, though, you need to work around it when installing PHPUnit using Composer. If you use PHPUnit from a PHP Archive (PHAR), which you should: it's the recommended best practice, then you are not affected by this issue. More details can be found here: sebastianbergmann/phpunit#5033 (comment) |
@sebastianbergmann When do you think PhpUnit will be installable through composer on php 8.2 without any workarounds? |
When PHPUnit 8.5.29 and PHPUnit 9.5.23 have been released. |
@sebastianbergmann Cool, thank you very much. |
The Prophecy 1.16 version has support for PHP 8.2 |
PHP 8.2 is beta now. It would be great if prophecy could unblock it in composer.json.
The text was updated successfully, but these errors were encountered: