Fix the class attached to methodnotfoundexception #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this now passes a string rather than an object. Is it expected ? |
|
@stof the exception's constructor parameter is |
The class was always being set to ObjectProphecy, which causes issues when trying to work out which class the method was not found on An alternative would have been to use $this->getProphecy()->reveal() but that may cause side effects
ciaranmcnulty
force-pushed
the
subjectpatch-notfoundexception
branch
from
f4caf05
to
736e992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class was always being set to ObjectProphecy, which causes issues when trying to work out which class the method was not found on
An alternative would have been to use
$this->getProphecy()->reveal()but that may cause side effectsFixing this resolves phpspec/phpspec#1350