Eases autoloading issue debugging #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it should impact the exit code; I think it should be implemented across formatters :-) |
|
@gquemener Is this ready to merge, in your opinion? It could do with a rebase |
|
Here's the current status on this PR. Display ignored specs (due to loading failure) using format:
|
|
If you're ok to have this halfway implemented, then you can merge it. Someone (me included) will probably open a new one to support the other formaters 🤔 Would that be acceptable in your opinion? |
|
Can you rebase to trigger a new build please? I think not implemented in all formatters is better than not implemented at all |
By being explicit about files that are ignored while running the specs suite, we help developers resolve autoloading issue.
gquemener
force-pushed
the
display_ignored_resources
branch
from
0bef372
to
c5ed836
Compare
|
Here we go, the branch is rebased 👌 |
|
Thanks @gquemener |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By being explicit about files that are ignored while running the specs
suite, we help developers resolve autoloading issue.
This PR superseds #1272
Let's agree on the scope of this feature: