ProgressCallback should report the actual downloaded amount of data and not the requested packets. #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s been received and not, if its just requested, as the requested packets might be more as the available and received data.
|
I'll try to take a look at this in the next few days - I've been without internet in Phantom Ranch (bottom of the Grand Canyon) and have one more days of hiking to do before I return to my hometown! |
|
You should definitely use your remaining time at the Grand Canyon instead of reviewing this pr :) But happy to get feedback, after you are back to business. |
|
I cherry picked this into the 1.0 branch and merged into 2.0 / 3.0 / master: Thanks! |
|
Thanks, are there any plans for the next release? |
terrafrost
referenced
this pull request
Aug 30, 2021
…s been received and not, if its just requested, as the requested packets might be more as the available and received data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$progressCallback should be called after a specific amount of data has been received and not, if its just requested, as the requested packets might be more as the available and received data.
This does not only solve the problem for $length = -1, because it requests 32 "slots" of max_packet_size packets nevertheless if the requested file is that big or not, it also solves the issue that requesting the data is not having the data delivered. Placing the call to $progressCallback later in the script, it reports the actual received amount of data.