Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SFTP::rawlist gives same results regardless of statcache #1287

Closed
wants to merge 2 commits into from
Closed

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Aug 13, 2018

Previously SFTP::rawlist gave different results depending on whether the
stat cache was enabled or not. With the stat cache turned off it did not
treat directories correctly, as it relied on the stat cache even though
it was not populated.

Previously SFTP::rawlist gave different results depending on whether the
stat cache was enabled or not. With the stat cache turned off it did not
treat directories correctly, as it relied on the stat cache even though
it was not populated.
@terrafrost
Copy link
Member

I cherry-picked this into the 1.0 branch and merged this into 2.0 and master.

I also fixed the failing unit test (changed stat to lstat; the issue is that an earlier method creates a symlink in self::$scratchDir)

Thanks!

@terrafrost terrafrost closed this Aug 18, 2018
terrafrost referenced this pull request Aug 21, 2018
Previously SFTP::rawlist gave different results depending on whether the
stat cache was enabled or not. With the stat cache turned off it did not
treat directories correctly, as it relied on the stat cache even though
it was not populated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants