Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subject pattern configurable option #916

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Add subject pattern configurable option #916

merged 1 commit into from
Jul 14, 2021

Conversation

antode
Copy link
Contributor

@antode antode commented Jul 9, 2021

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

I work in a Russian-speaking team and type/scope checks fails when the subject is written in only Russian.
it would be great if we can define type_scope_conventions.subject_pattern like:

type_scope_conventions:
  - types: []
  - scopes: ~
  - subject_pattern: >-
      ([a-zA-Zа-яА-Я0-9-_ #@'\/\"]+)

@veewee veewee added this to the 1.3.4 milestone Jul 13, 2021
@veewee veewee merged commit f8d1cc3 into phpro:master Jul 14, 2021
@veewee
Copy link
Contributor

veewee commented Jul 14, 2021

Nice addition, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants