Remove the --prefer-lowest and add a platform config for the phar file #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commands for building the phar file
jakzal
reviewed
Aug 16, 2019
kylekatarnls
approved these changes
Aug 17, 2019
jakzal
approved these changes
Aug 17, 2019
tvbeek
deleted the
remove_the_prefer-lowest_while_building_the_phar_file
branch
|
@jakzal and @kylekatarnls thanks for the feedback and change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the --prefer-lowest and add a platform config to the composer commands for building the phar file.
This is pointed out in #653 (comment) and I suspect a fix for #569