Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RuleSetFactory.php #659

Merged
merged 1 commit into from Aug 9, 2019
Merged

Update RuleSetFactory.php #659

merged 1 commit into from Aug 9, 2019

Conversation

SailorMax
Copy link
Contributor

@SailorMax SailorMax commented Aug 9, 2019 •
edited by kylekatarnls

Deprecated: implode(): Passing glue string after array is deprecated

Fixes #658

@SailorMax
Update RuleSetFactory.php
b0a4519 
Deprecated: implode(): Passing glue string after array is deprecated
@SailorMax SailorMax mentioned this pull request Aug 9, 2019
Closed
6 tasks
kylekatarnls
kylekatarnls approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix.

@kylekatarnls kylekatarnls added this to the 2.7.1 milestone Aug 9, 2019
@tvbeek tvbeek merged commit a4fe42b into phpmd:master Aug 9, 2019
@tvbeek
Copy link
Member

tvbeek commented Aug 9, 2019

@SailorMax Thanks for the issue and your PR 👍

@SailorMax SailorMax deleted the patch-1 branch August 9, 2019 15:46
@kylekatarnls kylekatarnls modified the milestones: 2.7.1, 2.8.0 Oct 19, 2019
@dereuromark
Copy link

Hi!
I saw you added this to the 2.8 milestone.

Any way you could instead patch this out in 2.7.1? Or fasttrack 2.8.0?
We already adjusted our test suite to also run 7.4 and make sure we are compatible to the release next week. But we have tons of deprecation warnings in travis etc. We would really appreciate if those could be patched out or something :)
Thank you!

kylekatarnls added a commit that referenced this pull request Dec 4, 2019
@kylekatarnls
Add missing #659 PR
020b62e
@shanezhiu shanezhiu mentioned this pull request Sep 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvbeek tvbeek tvbeek approved these changes

@roukmoute roukmoute roukmoute approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees

@SailorMax SailorMax

Labels
Compatibility php7.4
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Deprecated: implode(): Passing glue string after array is deprecated.
5 participants
@SailorMax @tvbeek @dereuromark @roukmoute @kylekatarnls