Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IfStatementAssignment violation message #657

Merged
merged 1 commit into from Aug 8, 2019
Merged

Fix IfStatementAssignment violation message #657

merged 1 commit into from Aug 8, 2019

Conversation

Jir4
Copy link
Contributor

@Jir4 Jir4 commented Aug 8, 2019

Fix #655

kylekatarnls
kylekatarnls approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@kylekatarnls kylekatarnls added this to the 2.7.1 milestone Aug 8, 2019
ravage84
ravage84 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@ravage84 ravage84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking CI Builds are unrelated. We are working on it, already.

@Jir4
Copy link
Contributor Author

Jir4 commented Aug 8, 2019

@ravage84 it did not worry me, I do not see how my change could have broken anything ^^

@ravage84
Copy link
Member

ravage84 commented Aug 8, 2019

@Jir4 my comment was just informative for other maintainers

@ravage84 ravage84 merged commit 82ac5bf into phpmd:master Aug 8, 2019
@Jir4 Jir4 deleted the fix-ifstatementassigment-message branch August 9, 2019 13:52
@kylekatarnls kylekatarnls modified the milestones: 2.7.1, 2.8.0 Oct 19, 2019
kylekatarnls added a commit that referenced this pull request Nov 1, 2019
@kylekatarnls
Added #657 mention
aa90c96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVaughn MarkVaughn MarkVaughn approved these changes

@ravage84 ravage84 ravage84 approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Bug
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Type in IfStatementAssignment violation message
4 participants
@Jir4 @ravage84 @MarkVaughn @kylekatarnls