Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #650 Use pretty tables to handle multi-line #652

Merged
merged 1 commit into from Aug 5, 2019
Merged

Fix #650 Use pretty tables to handle multi-line #652

merged 1 commit into from Aug 5, 2019

Conversation

kylekatarnls
Copy link
Member

Advantages:

Disadvantages:

  • A bit more difficult to edit

MarkVaughn
MarkVaughn approved these changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@MarkVaughn MarkVaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tvbeek
tvbeek approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@tvbeek tvbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this table format.

@tvbeek tvbeek merged commit b487b11 into phpmd:master Aug 5, 2019
@kylekatarnls
Copy link
Member Author

And the result is better in HTML too 🗡 http://phpmd.org/rules/naming.html

@kylekatarnls kylekatarnls deleted the feature/650-fix-tables branch August 5, 2019 20:23
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVaughn MarkVaughn MarkVaughn approved these changes

@tvbeek tvbeek tvbeek approved these changes

Assignees
No one assigned
Labels
Documentation Website
Milestone
2.x (unspecific)
Development

Successfully merging this pull request may close these issues.

Property Lists get merged together on Website
4 participants
@kylekatarnls @MarkVaughn @tvbeek @ravage84