Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the doc of Clean Code Rules. #645

Merged
merged 2 commits into from Jul 31, 2019
Merged

Fix the doc of Clean Code Rules. #645

merged 2 commits into from Jul 31, 2019

Conversation

poplary
Copy link
Contributor

@poplary poplary commented Jul 31, 2019

The rule name "DuplicateArrayKey" is wrong, while it should be "DuplicatedArrayKey"

poplary and others added 2 commits July 31, 2019 17:41
@poplary
Fix the doc of Clean Code Rules.
621d402 
The rule name "DuplicateArrayKey" is wrong, while it should be "DuplicatedArrayKey"
@kylekatarnls
Fix underlining length for DuplicatedArrayKey
510f63b
@ravage84 ravage84 added this to the 2.7.1 milestone Jul 31, 2019
@ravage84 ravage84 merged commit d0a55d5 into phpmd:master Jul 31, 2019
@poplary poplary deleted the fix-doc branch August 1, 2019 04:09
@kylekatarnls kylekatarnls modified the milestones: 2.7.1, 2.8.0 Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravage84 ravage84 ravage84 approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Documentation
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poplary @ravage84 @kylekatarnls