Add a renderer which writes an ANSI report string #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
reviewed
Feb 11, 2019
PtrTn
force-pushed
the
ansi-report-renderer
branch
from
98cd719
to
8553415
Compare
MarkVaughn
previously approved these changes
Jul 1, 2019
…ort-renderer # Conflicts: # README.rst # src/main/php/PHPMD/TextUI/CommandLineOptions.php # src/test/php/PHPMD/TextUI/CommandLineOptionsTest.php
kylekatarnls
previously approved these changes
Jul 28, 2019
|
Resolved conflicts with master branch. |
|
Thanks for the effort @kylekatarnls 😄 |
MarkVaughn
previously approved these changes
Jul 29, 2019
BackEndTea
previously approved these changes
Jul 29, 2019
|
What if we replace the current text renderer but add a |
|
There might be reasons to keep the default text renderer without breaking expected behavior? |
kylekatarnls
dismissed stale reviews from BackEndTea, MarkVaughn, and themself
via
839a182
kylekatarnls
approved these changes
Jul 30, 2019
|
Sorry guys, my commit staled your review but we had "four renderers" when adding ANSI would have make this statement wrong. I removed it so we don't have to maintain this count. |
MarkVaughn
approved these changes
Aug 5, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented an ANSI renderer which should improve the experience for users reading a report straight from the command line.
Using the ANSI renderer a report without violations will look something like this:
A report which does contain either a violation, an error or both will look like:
