Add 'ignore-namespaces' option to DevelopmentCodeFragment #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 11, 2018 10:23
|
This looks promising, can you rebase or merge in the new code to see if the tests pass? |
kylekatarnls
previously approved these changes
Jul 28, 2019
…v-frag-ns-ignore # Conflicts: # composer.lock
kylekatarnls
approved these changes
Jul 29, 2019
tvbeek
approved these changes
Aug 13, 2019
|
@tariq86 Thanks for the merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
What: Add new
ignore-namespacesproperty toDevelopmentCodeFragmentrule, from the Design ruleset.How: Declare new property
ignore-namespaceswith a default value offalseto avoid behavior changes. If it is enabled, then the namespace will be stripped from the function beforeWhy: As noted in #532, the current implementation is not detecting unwanted functions in namespaced classes. This is happening because
$node->findChildrenOfType('FunctionPostfix')is returning the method names prefixed with the namespace. In other words,var_dump()is being returned as\App\Namespace::var_dump()). This is causing thein_arraycheck for dev. functions to fail.