Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FQSEN resolving on see,covers,uses #226

Merged
merged 1 commit into from Sep 2, 2020

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Jun 18, 2020

The See, Covers and Use tags can reference also methods, properties and
constants. Which means that the FqsenResolver cannot handle those properly.
This patch fixes that issue.

To not break backwards compatibilty I had to duplicate the fix over the tags. :-(

@jrfnl
Copy link
Contributor

jrfnl commented Jun 19, 2020

Just a little note which may or may not impact this PR: @covers can not use unqualified names. PHPUnit demands that these are always fully qualified.

Please note that this annotation requires a fully-qualified class name (FQCN).

Source: https://phpunit.readthedocs.io/en/9.2/annotations.html#appendixes-annotations-covers-tables-annotations

The See, Covers and Use tags can reference also methods, properties and
constants. Which means that the FqsenResolver cannot handle those properly.
This patch fixes that issue.
@jaapio jaapio force-pushed the fix-resolve-all-fqsen-formats branch from 5422ef5 to 73650dd Compare September 2, 2020 20:51
@jaapio
Copy link
Member Author

jaapio commented Sep 2, 2020

I think having support for unqualified names is on the wishlist for phpunit. But they don't want to implement that themselves. According to PRS-19 these tags do have support for unqualified names.

@jaapio jaapio merged commit 86733dc into master Sep 2, 2020
@jaapio jaapio deleted the fix-resolve-all-fqsen-formats branch September 2, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants