Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl error while recording cassette with PHP 8 #390

Open
skyferix opened this issue May 17, 2023 · 1 comment
Open

Curl error while recording cassette with PHP 8 #390

skyferix opened this issue May 17, 2023 · 1 comment
Labels

Comments

@skyferix
Copy link

skyferix commented May 17, 2023

Using PHP 8.1.19.
In Utils/HttpClient class send method there is assertion for resource.
curl_init returns CurlHandle class object.
So the resource check condition will always fail.

Worth to mention that initially it was used to make the soap request witch used the HttpClient for the actual request send.

Commenting that line out helped as the main purpose was to record the request for test cases.

I am not that advanced to be sure about why that assert was there in the first place. (feel free to prove me wrong if it is expected behaviour)
The fix could be the adding the early return instance of CurlHandle check right before the is_resource check

@skyferix skyferix changed the title Cassette recording with PHP 8 Curl error while recording cassette with PHP 8 May 17, 2023
@higidi higidi added the Bug Something isn't working label Sep 12, 2023
@higidi
Copy link
Contributor

higidi commented Sep 12, 2023

Cannot find the resource check in the latest master. Which version do you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants