Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCR::turnOff() does not restore stream wrappers #350

Open
robertpustulka opened this issue May 13, 2021 · 0 comments
Open

VCR::turnOff() does not restore stream wrappers #350

robertpustulka opened this issue May 13, 2021 · 0 comments

Comments

@robertpustulka
Copy link

Looks like Soap and Curl Hooks don't restore the original stream wrapper when calling disable():

https://github.com/php-vcr/php-vcr/blob/master/src/VCR/LibraryHooks/CurlHook.php#L93-L122

https://github.com/php-vcr/php-vcr/blob/master/src/VCR/LibraryHooks/SoapHook.php#L95-L122

$this->processor->restore() should be called to effectively restore the original wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertpustulka