Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KernelEvents for TurnOn and TurnOff recodings #7

Open
monobook opened this issue Nov 3, 2016 · 2 comments
Open

Use KernelEvents for TurnOn and TurnOff recodings #7

monobook opened this issue Nov 3, 2016 · 2 comments

Comments

@monobook
Copy link

monobook commented Nov 3, 2016 •
edited

Hi. I've got idea about testing Behat scenarios with php-vcr...

Why should we put logic in AppKernel.php like this and in app_test.php like this? Maybe use Kernel Events for this?

  1. On KernelEvents::REQUEST with high priority we do all what we do on AppKernel.php
  2. On KernelEvents::TERMINATE with lowest priority we "eject" cassette and "stop recording"

Conclusions:

  1. we have clean AppKernel.php
  2. we could change dynamic behavior via EventSubscriber logic.

PS: Maybe It would be nice to create Extension for Behat?
@monobook
Copy link
Author

monobook commented Nov 3, 2016

What do you think, @K-Phoen?

@monobook
Copy link
Author

monobook commented Jul 5, 2017

@adri ping? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monobook