Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this integration test work with PHPUnit 10 #59

Open
nyamsprod opened this issue Feb 26, 2023 · 1 comment
Open

Make this integration test work with PHPUnit 10 #59

nyamsprod opened this issue Feb 26, 2023 · 1 comment

Comments

@nyamsprod
Copy link
Contributor

Description

Make this integration test work with PHPUnit 10.

Additional context

Some changes may lead to have a new major version for this to work see https://getrector.com/blog/how-to-upgrade-to-phpunit-10-in-diffs

@dbu
Copy link
Contributor

dbu commented Feb 26, 2023

agree we should do this. if we can keep it compatible, with phpunit 9, its nice. but if it is too complicated, we can release a new minor version for that. no need for a major work, as long as usage of the integration tests does not need to change - composer dependencies will make sure a new version for phpunit 10 can not get installed with phpunit 9.

do you want to work on this? i'd be happy to review a pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants