Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emulated clients #124

Closed
dbu opened this issue Dec 2, 2018 · 4 comments
Closed

emulated clients #124

dbu opened this issue Dec 2, 2018 · 4 comments
Milestone

Comments

@dbu
Copy link
Contributor

dbu commented Dec 2, 2018

in the classes EmulatedHttpAsyncClient and EmulatedHttpClient we have a comment saying "This should be replaced by an anonymous class in PHP 7.". we now bump to php 7, so we could do this. however, i am not sure its worth it. right now, we have spec tests for those emulated clients. if we make them anonymous classes, we can't test them separately anymore, and the FlexibleHttpClient will become very complicated to test, i fear.

@dbu dbu added this to the v2.0.0 milestone Dec 2, 2018
@dbu
Copy link
Contributor Author

dbu commented Dec 2, 2018

@sagikazarmark i think you originally wrote those - what is your opinion on this question?

@sagikazarmark
Copy link
Member

sagikazarmark commented Dec 4, 2018

I think it's okay to keep them. When I wrote those comments I don't think we had any real life usage for the emulated clients

@joelwurtz
Copy link
Member

Agree with that also we should keep them and remove those comments about anonymous class

@dbu
Copy link
Contributor Author

dbu commented Dec 8, 2018

i am removing the comments in #123. and marking them as final without adding an interface, because the users should only typehint HttpClient / HttpAsyncClient and not care about them specifically being emulated clients.

@dbu dbu closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants