You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the classes EmulatedHttpAsyncClient and EmulatedHttpClient we have a comment saying "This should be replaced by an anonymous class in PHP 7.". we now bump to php 7, so we could do this. however, i am not sure its worth it. right now, we have spec tests for those emulated clients. if we make them anonymous classes, we can't test them separately anymore, and the FlexibleHttpClient will become very complicated to test, i fear.
The text was updated successfully, but these errors were encountered:
i am removing the comments in #123. and marking them as final without adding an interface, because the users should only typehint HttpClient / HttpAsyncClient and not care about them specifically being emulated clients.
in the classes EmulatedHttpAsyncClient and EmulatedHttpClient we have a comment saying "This should be replaced by an anonymous class in PHP 7.". we now bump to php 7, so we could do this. however, i am not sure its worth it. right now, we have spec tests for those emulated clients. if we make them anonymous classes, we can't test them separately anymore, and the FlexibleHttpClient will become very complicated to test, i fear.
The text was updated successfully, but these errors were encountered: