Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use short array syntax in README.md #342

Merged
merged 1 commit into from Jun 5, 2019

Conversation

localheinz
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

This PR

  • uses short array syntax in README.md

Why?

Since this package requires at least PHP 7.1, I think it's safe to use short array syntax in code examples.

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! yes we use short array syntax in our code, no reason not to use it in the documentation as well.

@dbu dbu merged commit 961cc9c into php-http:master Jun 5, 2019
@localheinz localheinz deleted the feature/readme branch June 5, 2019 08:24
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants