Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clean up phpunit.xml.dist #341

Merged
merged 3 commits into from Jun 4, 2019
Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 4, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

This PR

  • references phpunit.xsd in phpunit.xml.dist
  • removes an invalid attribute syntaxCheck
  • merges duplicate php nodes

Why?

Running

$ composer install && composer test

on current master yields

PHPUnit 7.4.5 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 8:
  - Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is not allowed.

  Line 33:
  - Element 'php': This element is not expected.

  Test results may not be as expected.

@dbu dbu merged commit b21c39d into php-http:master Jun 4, 2019
@dbu
Copy link
Collaborator

dbu commented Jun 4, 2019

thanks, keep them coming!

@localheinz localheinz deleted the fix/phpunit branch June 4, 2019 12:06
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants