Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on undefined variable when a client is named default in config #332

Merged
merged 1 commit into from Apr 12, 2019
Merged

Fix error on undefined variable when a client is named default in config #332

merged 1 commit into from Apr 12, 2019

Conversation

leon38
Copy link

@leon38 leon38 commented Apr 11, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets no
Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Fix an undefined variable $serviceId when the first client is named default in configuration

Why?

Fix an undefined variable $serviceId when the first client is named default in configuration

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • [ x] Documentation pull request created (if not simply a bugfix)

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks like we miss a test somewhere...

@dbu dbu merged commit 1fddc94 into php-http:master Apr 12, 2019
@dbu
Copy link
Collaborator

dbu commented Apr 12, 2019

i tagged 1.15.1 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants