Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support common client 2.x #293

Merged
merged 7 commits into from Dec 29, 2018
Merged

Support common client 2.x #293

merged 7 commits into from Dec 29, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 28, 2018

Follow up on #291

This uses the forward compatibility layer introduced in php-http/client-common#132

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need a release of client-common. looks good to me, lets merge once we tagged 1.9 of client-common.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 29, 2018

I've tested this and it is working.

I also added

     "prefer-stable": true,
     "minimum-stability": "dev"

Which means that we dont need to wait for a release of 1.9 of client-common to actually merge this.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 29, 2018

We allow too many versions. That is why Travis is failing: https://travis-ci.org/php-http/HttplugBundle/jobs/473334912

I updated all symfony related versions. We only support the latest patch version for all supported minor versions.

@Nyholm Nyholm merged commit 599e7d4 into master Dec 29, 2018
@Nyholm Nyholm deleted the common-2.0 branch December 29, 2018 15:04
@sowbiba
Copy link
Contributor

sowbiba commented Jan 3, 2019

I cannot install latest version of httplug-bundle because

  Problem 1
    - Installation request for php-http/httplug-bundle 1.14.0 -> satisfiable by php-http/httplug-bundle[1.14.0].
    - php-http/httplug-bundle 1.14.0 requires php-http/cache-plugin ^1.6 -> satisfiable by php-http/cache-plugin[1.6.x-dev] but these conflict with your requirements or minimum-stability.

client-common 1.9 is released, will cache-plugin be released soon ? 🙏

Thanks

@Nyholm
Copy link
Member Author

Nyholm commented Jan 3, 2019

Yeah, we are waiting for other releases. You could try it out by adding the following in composer.json:

"php-http/cache-plugin": "dev-master as 1.7",
"php-http/logger-plugin": "dev-master as 1.7",
"php-http/stopwatch-plugin": "dev-master as 1.7"

They should all be released as soon as possible.
If you want to help, you can review these 3 plugins and update the change logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants