New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support common client 2.x #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need a release of client-common. looks good to me, lets merge once we tagged 1.9 of client-common.
I've tested this and it is working. I also added
Which means that we dont need to wait for a release of 1.9 of client-common to actually merge this. |
We allow too many versions. That is why Travis is failing: https://travis-ci.org/php-http/HttplugBundle/jobs/473334912 I updated all symfony related versions. We only support the latest patch version for all supported minor versions. |
I cannot install latest version of httplug-bundle because
client-common 1.9 is released, will cache-plugin be released soon ? 🙏 Thanks |
Yeah, we are waiting for other releases. You could try it out by adding the following in composer.json: "php-http/cache-plugin": "dev-master as 1.7",
"php-http/logger-plugin": "dev-master as 1.7",
"php-http/stopwatch-plugin": "dev-master as 1.7" They should all be released as soon as possible. |
Follow up on #291
This uses the forward compatibility layer introduced in php-http/client-common#132