base64 encode SNS Header message attribure #1308

martinssipenko · 2023-07-12T11:11:12Z

martinssipenko · 2023-07-12T11:36:48Z

This solution would not work in cases where there are multiple distinct services using enqueue for cross-service communication via messages because this change would introduce bease64 encoding of messages, but if there are other services using an older version of this library, that can not base64 decode messages, the message consumption would break.

rolandsusans · 2023-07-13T10:54:41Z

pkg/sns/SnsProducer.php

@@ -51,7 +51,7 @@ public function send(Destination $destination, Message $message): void
            'MessageAttributes' => [
                'Headers' => [
                    'DataType' => 'String',
-                    'StringValue' => json_encode([$message->getHeaders(), $message->getProperties()]),
+                    'StringValue' => base64_encode(json_encode([$message->getHeaders(), $message->getProperties()])),


Maybe we can leave this without encoding base64 for now (keep changes not breaking).
In the next major release, we can add base64_encode part. 🤔

base64 encode SNS Header message attribure

8ca9a12

rolandsusans approved these changes Jul 12, 2023

View reviewed changes

rolandsusans reviewed Jul 13, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

base64 encode SNS Header message attribure #1308

base64 encode SNS Header message attribure #1308

martinssipenko commented Jul 12, 2023

martinssipenko commented Jul 12, 2023

rolandsusans Jul 13, 2023 •

edited

base64 encode SNS Header message attribure #1308

Are you sure you want to change the base?

base64 encode SNS Header message attribure #1308

Conversation

martinssipenko commented Jul 12, 2023

martinssipenko commented Jul 12, 2023

rolandsusans Jul 13, 2023 • edited

Choose a reason for hiding this comment

rolandsusans Jul 13, 2023 •

edited