Updated beberlei/assert to version 3.x.x & PHP min version 7.0 #32
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panosru
commented
Jan 22, 2019
panosru
changed the title
icanhazstring
requested changes
Jan 22, 2019
There was a problem hiding this comment.
Hi @panosru thanks for PR.
Looks almost good, a few adjustments and I can merge this asap.
|
@icanhazstring Please check my latest commit if it meets the projects requirements |
icanhazstring
approved these changes
Jan 22, 2019
|
Thanks! Merged. |
|
@panosru tagged 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because I tried to require that library into one of my projects but I got:
And also, why not update to the latest version since it does not break anything.