Version 1.x #29
Merged
Version 1.x #29
+941
−359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop support php < 7.2 - update phpunit to 7.5 - add strict types in all files - add return type and argument type hinting in all files - bump copyright to 2019
Nitpick-CI
reviewed
Jan 13, 2019
Fix typo
Fixed issues with max level of phpstan.
|
Edith: And fixed ;) |
Add phpstan config to ignore export. Add support for symfony/console ^4 to avoid conflicts
* Made AbstractFetcher accept more then one annotation type * Add inherit annotation This will serve as a contract inherit flag. It will take all existing annotations (ensure, verify, invariant) and check current as well as parent classes for contracts * Update Inherit implementation - Inherit will now always inherit contracts (despite missing @inheritdoc) - provide Inherit tests - update Demo implementation - update Readme with Inherit documentation
* Updated beberlei/assert to version 3.x.x * Minimum PHP Support v7.0 * Moved beberlei/assert to require-dev and added additional directives in composer.json
- drop support php < 7.2 - update phpunit to 7.5 - add strict types in all files - add return type and argument type hinting in all files - bump copyright to 2019
Fixed issues with max level of phpstan.
Add phpstan config to ignore export. Add support for symfony/console ^4 to avoid conflicts
Fix some issues in new code from master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bump phpdeal/framework to php7.2 and version 1.x.
The branch 1.x should replace master if this PR gets accepted.
0.x is only there for backward fixes, but can probably be dropped as well.
List of changes: