Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use into with a non-empty list as this is deprecated in 1.8.0 #121

Merged

Conversation

Gazler
Copy link
Member

@Gazler Gazler commented Jan 25, 2019

@quolpr
Copy link

quolpr commented Jan 25, 2019

Wow, so fast!

@arjan
Copy link

arjan commented Feb 2, 2019

Any chance this gets merged soon? Warnings in the test output driving me nuts ;-)

@arjan
Copy link

arjan commented Feb 18, 2019

@chrismccord could you take a look at this, it is a trivial fix.

@princemaple
Copy link
Contributor

Sorry about pinging again @chrismccord , this is really taking over the debugging log. If someone could take a look and merge (and make a release 😉) we'd be immensely thankful.

@arjan
Copy link

arjan commented Feb 23, 2019

Maybe we could ping another maintainer... @josevalim ? 😜

@josevalim josevalim merged commit 316fdd8 into phoenixframework:master Feb 23, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@denvaar
Copy link
Contributor

denvaar commented Feb 24, 2019

Thank you for this update!

@princemaple
Copy link
Contributor

Looks like Jose doesn't have the permission to push this one to hex... 😂

@Gazler Gazler deleted the fix/deprecation-elixir-1-8-0 branch February 25, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants