Refactor form recovery #3201
Open
Refactor form recovery #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
force-pushed
the
sd-form-recovery
branch
from
ea6c28a
to
0e3ec35
Compare
SteffenDE
added a commit
that referenced
this pull request
Apr 14, 2024
SteffenDE
added a commit
that referenced
this pull request
Apr 14, 2024
SteffenDE
force-pushed
the
sd-form-recovery
branch
from
0e3ec35
to
236df46
Compare
SteffenDE
added a commit
that referenced
this pull request
Apr 27, 2024
SteffenDE
force-pushed
the
sd-form-recovery
branch
from
70f452f
to
0233973
Compare
SteffenDE
added a commit
that referenced
this pull request
May 3, 2024
SteffenDE
force-pushed
the
sd-form-recovery
branch
from
18f4f9d
to
a0035d7
Compare
SteffenDE
force-pushed
the
sd-form-recovery
branch
from
a0035d7
to
bed9178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the form recovery feature to fix a problem with phx-target='selector' not working. It also stores form elements until all child views have been mounted, which allows form recovery to work in nested LiveViews.
Fixes #2281.
Fixes #3200.