Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openEditorAtDef and openEditorAtCaller only work once per load in Firefox #152

Open
markolson-powerschool opened this issue Mar 7, 2024 · 1 comment

Comments

@markolson-powerschool
Copy link

With PLUG_EDITOR setup and the sample from the README included, jumping to definitions and callers works in Safari and Chrome, but only once per page-load in Firefox.

I've tried to do some debugging in Firefox and see that on reloader.openEditorAt*(e.target);, reloader is still a valid reference, but a breakpoint inside of openEditorAt* is never hit after the first invocation. Even more oddly, a breakpoint in openFullPath is never hit, but we still get the console output of opening full path etc/etc/etc..

@thomasfortes
Copy link

thomasfortes commented May 17, 2024

I was able to track the problem to here, if you check this.channel one line before the linked one on the first call to open it will show that the channel state is joined but joinPush already is errored, after the first one the channel itself is errored and we can't push more through it.

Another thing is that if you keep track of the WS using the NetworkTab of the devtools on Firefox you can see that immediately after receiving a response from the livereloader it disconnects with a Connection Closed 1000

I hope this is something that helps start figuring it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants