Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "dark mode" theme #343

Open
mcrumm opened this issue Nov 14, 2021 · 4 comments
Open

Support "dark mode" theme #343

mcrumm opened this issue Nov 14, 2021 · 4 comments
Labels
design Design related changes

Comments

@mcrumm
Copy link
Member

mcrumm commented Nov 14, 2021

I am sure to be simplifying a bit, but I would like to explore adding a config option for dark_mode that is a boolean and we load a CSS file that is so named.

Edit: Adjusted for dark mode discussion

@mcrumm
Copy link
Member Author

mcrumm commented Nov 14, 2021

// @archdragon

@josevalim
Copy link
Member

I am not a big fan of this approach because we have a non-reasonable amount of custom CSS, so what happens? Is this custom CSS meant to work with all possible themes? And then even if someone were to reimplement all of the CSS in a custom theme, what happens when we do a new version, where we add/change/remove classes? So to me this is all a bit too coupled for us to allow any theme to be plugged in.

@mcrumm
Copy link
Member Author

mcrumm commented Nov 14, 2021

I will be honest– I made a naive assumption that things were mostly built-in.

I agree on all points. If the theme is not easily swappable then there is little benefit, and backwards compatibility is a real concern.

I am happy to close this as-is, but I wonder if any amount of "customization" is possible. For instance, would we accept a PR to support a "dark mode"?

@josevalim
Copy link
Member

josevalim commented Nov 14, 2021

We should accept a PR for a dark mode, yeah. :)

@mcrumm mcrumm changed the title Support custom Bootstrap theme Support "dark mode" theme Nov 14, 2021
@josevalim josevalim added the design Design related changes label Jan 30, 2022
@mcrumm mcrumm mentioned this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related changes
Projects
None yet
Development

No branches or pull requests

2 participants