Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default root layout's html content width issue. #5656

Open
Dinesh563 opened this issue Dec 4, 2023 · 2 comments · May be fixed by #5662
Open

default root layout's html content width issue. #5656

Dinesh563 opened this issue Dec 4, 2023 · 2 comments · May be fixed by #5662

Comments

@Dinesh563
Copy link

Environment

  • Elixir version (elixir -v): 1.15.0
  • Phoenix version (mix deps): 1.7.10
  • Operating system: Ubuntu 20.04.6 LTS (Intel® Core™ i7-10750H CPU @ 2.60GHz × 12 )

Actual behavior

On Generating new phoenix project with mix phx.new the default root layout body element's width is not up to the full screen.
which generates a small gap between the right wall of the screen and the html content.
Note: i have not touched or written any css.

Screenshot from 2023-12-04 07-38-04-copy

Expected behavior

The default root layout's html must have width set to full screen.There should not be any gap between html content and the right screen.

@Dinesh563 Dinesh563 linked a pull request Dec 10, 2023 that will close this issue
@rhcarvalho
Copy link
Contributor

Hi @Dinesh563! 👋

The current behavior was introduced in 7ab3d91 (later amended by 3085b13) in response to #5101.

I agree the reserved space can look strange, particularly for pages that would otherwise have no scrollbars and I have removed that in some projects. But I think any changes to the current root template would need to take the original issue it was trying to solve into account, and at least test that a proposed patch doesn't accidentally re-introduce the problem.

Since the template is just a template, we can also change it in our projects if the design asks for it, and deal with the consequences ourselves (we all might have different trade-offs at hand, for example not be using modals at all).

@josevalim
Copy link
Member

I would probably just remove the class altogether. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants