Add HTMLFormatter to umbrella root #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrocp
added a commit
to leandrocp/phoenix_live_view
that referenced
this pull request
Apr 19, 2022
josevalim
pushed a commit
to phoenixframework/phoenix_live_view
that referenced
this pull request
Apr 19, 2022
chrismccord
pushed a commit
that referenced
this pull request
May 6, 2022
chrismccord
added a commit
that referenced
this pull request
May 6, 2022
This reverts commit 16021a6.
ryansch
pushed a commit
to outstand/phoenix
that referenced
this pull request
May 9, 2022
ryansch
pushed a commit
to outstand/phoenix
that referenced
this pull request
May 9, 2022
This reverts commit 16021a6.
Zurga
pushed a commit
to Zurga/phoenix_live_view
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4793 (comment)
Confirmed the behavior related on phoenixframework/phoenix_live_view#1969 by generating a new umbrella app locally. I get the same exception if there is no
plugins: [Phoenix.LiveView.HTMLFormatter]on umbrella root.