Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route_info lookup #3419

Merged
merged 1 commit into from Jun 3, 2019
Merged

Add route_info lookup #3419

merged 1 commit into from Jun 3, 2019

Conversation

chrismccord
Copy link
Member

@josevalim any input on how we should partially make %Phoenix.Router.Route{} public? Still needs docs about what is and isn't private, but not sure what's best at the moduledoc/or router_info function doc level. Would appreciate your thoughts

@josevalim
Copy link
Member

I think all of the current fields are safe to expose, so it is probably a matter of making the module public and hiding the documentation for all other functions (or perhaps move those functions to another module, so we don't end-up @doc false everything).

@chrismccord chrismccord merged commit 3f157c3 into master Jun 3, 2019
chrismccord added a commit that referenced this pull request Jun 3, 2019
@josevalim josevalim deleted the cm-router-info branch June 12, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants