Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New umbrella config breaks watchers #3391

Closed
austinsmorris opened this issue May 1, 2019 · 0 comments
Closed

New umbrella config breaks watchers #3391

austinsmorris opened this issue May 1, 2019 · 0 comments

Comments

@austinsmorris
Copy link

austinsmorris commented May 1, 2019

Environment

  • Elixir version (elixir -v):
  • Phoenix version (mix deps): 1.4.4
  • NodeJS version (node -v):
  • NPM version (npm -v):
  • Operating system:

Issue

Now that there is only a top level config on a new umbrella project, the watchers that mix phx.new my_app --umbrella generates are incorrect.

In /config/dev.exs the endpoint config includes:

  watchers: [
    node: [
      "node_modules/webpack/bin/webpack.js",
      "--mode",
      "development",
      "--watch-stdin",
      cd: Path.expand("../assets", __DIR__)
    ]
  ]

Note the cd: Path.expand("../assets", __DIR__)

Since this config is now at the umbrella root instead of the web app root, it should be something like cd: Path.expand("../apps/my_app_web/assets", __DIR__).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant