Revert reconnect optimizations which introduced regressions #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismccord
changed the title
|
Tested this on our end and it solves the issue (Ping @simpers @malicaspeco) |
chrismccord
added a commit
that referenced
this pull request
Feb 12, 2019
Xiaobin0860
added a commit
to Xiaobin0860/phoenix
that referenced
this pull request
Feb 16, 2019
* phx/master: (26 commits) Support any struct with :endpoint key in helpers Inspect body in ConnTest.response/2 (phoenixframework#3267) update snippet to agree with latest phx.new (phoenixframework#3277) Only enable trim for HTML templates Revert reconnect optimizations which introduced regressions. Fixes phoenixframework#3161 (phoenixframework#3272) Reword sentence in Controllers guide (phoenixframework#3270) update documentation to reflect on function deprecations (phoenixframework#3269) Fix warning in presence Default log for render errors info should be debug Add jason to umbrella ecto deps. Fixes phoenixframework#3263 Add Elixir Slack community in the help column of the initial default page (phoenixframework#3262) Update heroku.md (phoenixframework#3241) add JavaPhoenixClient in 3rd party channels client libraries list (phoenixframework#3256) fix typespec for put_layout (phoenixframework#3253) Add version to umbrellas (mirror Elixir master) Fix references in guides (phoenixframework#3251) Add $PORT bind step in Heroku deployment guide (phoenixframework#3235) update link to mime types (phoenixframework#3249) Add Elixir 1.7 and 1.8 to Travis CI build matrix (phoenixframework#3248) Update learning.md (phoenixframework#3247) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3161