fix error: implicit conversion from float to int loses precision #1664
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alexander1000 thanks for the contribution, but AFAIK we do not make updates on the old-stable branch any longer. Is the issue still a problem in the current main branch? |
|
But your main branch is still a release candidate. And the full version 3.0.0 has not yet been released. Because of this, we have to use version 2.x and this blocks the transition to a new version of php. As soon as you release version 3.0, we will immediately switch to it. |
|
@Alexander1000 is this a blocker for builds, or just a timing issue? |
|
This breaks the build with an error in our ci/cd system. |
|
Ok. I'll push another stable release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implicit conversion from float to int loses precision in case when build work more than 1 minute
@mrook