Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and specs for traverse_and_update are wrong #285

Closed
josevalim opened this issue Jun 17, 2020 · 2 comments
Closed

Docs and specs for traverse_and_update are wrong #285

josevalim opened this issue Jun 17, 2020 · 2 comments
Labels
Projects

Comments

@josevalim
Copy link
Contributor

The docs say that it will receive an html_tag but the callback is also called for doctype/comment/pi nodes. I am not sure if you want to fix the specs/docs or the code. :)

@josevalim josevalim added the Bug label Jun 17, 2020
@philss philss added this to Needs triage in Bugs via automation Jun 18, 2020
@philss
Copy link
Owner

philss commented Jun 23, 2020

@josevalim thank you for catching it! 💜
I think the problem is in the docs, because the callback function needs to handle nodes for doctype/comment/pi in order to be able to change it. So we need to update the docs instead of removing the "feature".

@philss philss moved this from Needs triage to High priority in Bugs Jun 23, 2020
@josevalim
Copy link
Contributor Author

Cool, PR sent here #289.

Bugs automation moved this from High priority to Closed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bugs
  
Closed
Development

No branches or pull requests

2 participants