Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Floki.filter_out/2 now can filter out nodes #283

Merged
merged 2 commits into from Jun 21, 2020
Merged

feat: Floki.filter_out/2 now can filter out nodes #283

merged 2 commits into from Jun 21, 2020

Conversation

ckruse
Copy link
Contributor

@ckruse ckruse commented Jun 14, 2020

Regarding #282

philss
philss reviewed Jun 18, 2020
View reviewed changes
Copy link
Owner

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, @ckruse! Thank you! 💜 I added a comment.

lib/floki/filter_out.ex Outdated Show resolved Hide resolved
fix: use is_binary/1 instead of is_bitstring/1
e6e2abe 
Strings in Elixir are binaries, not bitstrings.
@philss philss merged commit 1bdc62d into philss:master Jun 21, 2020
@philss philss mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philss philss philss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckruse @philss