Check type of attribute values #189
Conversation
|
Hello, @katehedgpeth! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
There was a problem hiding this comment.
This sounds great to me, @katehedgpeth! I only added one minor issue to be fixed (please amend or rebase).
I would like to recommend running mix format path/of/file using the latest Elixir version if possible.
Thank you again! 😃
| defp build_attrs({attr, value}, attrs) do | ||
| defp build_attrs({attr, iodata}, attrs) when is_list(iodata) do | ||
| build_attrs({attr, IO.iodata_to_binary(iodata)}, attrs) | ||
| end |
There was a problem hiding this comment.
Please add one line after this end, since the formatter tells us to do.
katehedgpeth
force-pushed
the
attr-iodata
branch
from
c263c84
to
171c4dc
Compare
|
@philss apologies for the delay -- updated! |
|
@katehedgpeth no worries, thank you! |
fixes #188
Adds a type check to
Floki.RawHTML.build_attrs/2, to ensure that the attributes are a string before checking for double quotes inside of attributes.