Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literal field becomes optional in typescript #36

Open
jcampbell opened this issue Apr 24, 2023 · 0 comments
Open

Literal field becomes optional in typescript #36

jcampbell opened this issue Apr 24, 2023 · 0 comments

Comments

@jcampbell
Copy link

If I define a property using a Literal with a default value, it shows as optional in typescript. This is similar to #28 but, I think it should be treated differently because the value must be set, even by a client (the property is used as a discriminator in a union).

from typing import Literal
from pydantic import BaseModel


class MyModel(BaseModel):
  my_bool_property: Literal[False] = False

renders into

/* tslint:disable */
/* eslint-disable */
/**
/* This file was automatically generated from pydantic models by running pydantic2ts.
/* Do not modify it by hand - just update the pydantic models and then re-run the script
*/

export interface MyModel {
  my_bool_property?: false;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant