Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BannerComment should be set by using js2ts cli #33

Open
Kruptein opened this issue Jan 14, 2023 · 0 comments
Open

BannerComment should be set by using js2ts cli #33

Kruptein opened this issue Jan 14, 2023 · 0 comments

Comments

@Kruptein
Copy link

The json-schema-to-typescript cli already offers a flag to configure the bannerComment, which I assumed would be used by this project.

However specifying a custom bannerComment by doing something like poetry run pydantic2ts --json2ts-cmd "./node_modules/.bin/json2ts --bannerComment='sample banner'" did not replace the banner as anticipated, but instead adds it below the pydantic banner.

Context:
The tslint-ignore line is making my eslint very unhappy, this is removed in py2ts (although not yet released) and I hoped to manually set a banner without the tslint line.

Alternatively allowing the option to be set with pydantic2ts cli flags as requested in #16 would also work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant