New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kibana alert update #345

Draft

cgroschupp wants to merge 1 commit into phillbaker:master from cgroschupp:feature/update

Contributor

cgroschupp commented Mar 22, 2023

Fixes: #344


          feat: add kibana alert update

b5bf0e0

Owner

phillbaker commented Mar 23, 2023 via email

Thanks for the PR, please make sure that the tests cover this functionality!

On Wed, Mar 22, 2023 at 12:07 PM Christian Groschupp < ***@***.***> wrote: Fixes: #344 <#344> ------------------------------ You can view, comment on, or merge this pull request online at: #345 Commit Summary - b5bf0e0 <b5bf0e0> feat: add kibana alert update File Changes (1 file <https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345/files> ) - *M* es/resource_elasticsearch_kibana_alert.go <https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345/files#diff-093753ffb213e844c331ae0070b41968decb3639886d72beb35b66bebfafed1c> (66) Patch Links: - https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345.patch - https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345.diff — Reply to this email directly, view it on GitHub <#345>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXCKJB7QXX6CP6UQYVN43W5MPVDANCNFSM6AAAAAAWEBCMEE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Owner

phillbaker commented May 15, 2023

Following up on this, it looks like the PR failed to pass the linters, would you like to have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment