Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/O operation on closed file when uploading new Reading image #222

Closed
philgyford opened this issue Mar 1, 2020 · 2 comments
Closed

I/O operation on closed file when uploading new Reading image #222

philgyford opened this issue Mar 1, 2020 · 2 comments
Assignees
@philgyford
Labels
Bugs

Comments

@philgyford
Copy link
Owner

When trying to add a new book cover image when adding a Publication, the preview is missing when the Admin page refreshes.

View the publication detail page and it's a 500 error. Lots say "'ImageCacheFile' object is not subscriptable" and "I/O operation on closed file."
@philgyford philgyford added the Bugs label Mar 1, 2020
@philgyford philgyford self-assigned this Mar 1, 2020
@philgyford
Copy link
Owner Author

philgyford commented Mar 1, 2020 •
edited

Looks like our CustomS3Boto3Storage class needs changing: matthewwithanm/django-imagekit#391 (comment)

philgyford added a commit that referenced this issue Mar 1, 2020
@philgyford
Maybe fix error when uploading images to S3
502ff2b 
For #222
@philgyford
Copy link
Owner Author

Partially fixed... still get no thumbnail showing in Admin initially, and viewing Publication detail generates 500 error. But maybe 10 seconds later both work again.

philgyford added a commit that referenced this issue Mar 8, 2020
@philgyford
Maybe fix image uploading
ead4666 
The updated `CustomS3Boto3Storage` was resulting in an uploaded image
but not attaching it to the object. I'd copied the wrong version of
the code, which didn't `return` anything from the method.

For #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philgyford philgyford

Labels
Bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philgyford